Feature/cgd 47 #21
Feature/cgd 47 #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… into feature/CGD-47
There was a problem hiding this comment.
- Can you check your colors in the theme again. It looks like the secondary-content, accent, and accent-content colors aren't correct but also do a check again in case I missed a mistake somewhere else as well.
- I think this would be a good time to add some tests. I think for now just a simple unit test is fine. Write a test for the functionality of the theme toggle. Create a test folder in the components folder and put your test file in there with .test.tsx extension. Don't need barrel file for this since we're not going to need to access the test file anywhere else in the project.
|
There were some problems with the theming identified, so it needs to be changed. So you can hold off on updating the colors for now. I'll let you know when it's finalized. |
I think cypress runs tests that are only in cypress/e2e folder 🤔 |
you can use react testing library for the unit tests and cypress for the e2e tests. |
|
I have noticed that the profile image path is wrong, I'll fix it when I get home. |
There was a problem hiding this comment.
LGTM, just need to fix the avatar image import which @JaneMoroz has already referenced. After that it's good to merge.
Done! |
Description and impacts
Jira related story
CGD-47
Additional info
I used next-themes.